BIND 10 #2431: support flexible ordering/appearance of TTL, type and class in dns::MasterLoader

[BIND 10 Development]

#2431: support flexible ordering/appearance of TTL, type and class in
dns::MasterLoader
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  jinmei
            Priority:  medium        |                       Status:
           Component:  libdns++      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20121218
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  5             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:14 muks]:

 > > - I suggest using `InternalException` instead of `BadValue` and remove
 > >   the comments.
 > > {{{#!cpp
 > >             // It doesn't really matter much what type of exception
 > >             // we throw, we catch it just below.
 > >             isc_throw(isc::BadValue, "Class mismatch: " << *rrclass <<
 > >                       "vs. " << zone_class_);
 > > }}}
 > >   `InternalException` seems to be introduced for this exact purpose,
 > >   but I guess at the time of the use of `BadValue` it wasn't there.
 >
 > Done. Please check the `trac2431_2` branch for this.

 As commented above, I'd remove this comment:
 {{{#!cpp
              // It doesn't really matter much what type of exception
              // we throw, we catch it just below.
 }}}
 Otherwise, the branch is okay for merge.

 > I'll keep this bug open and close it during the next sprint. I want the
 rest of the code also to get into master soon.

 Yeah, that's fine, please keep it assigned to me.  I'll review the
 rest of the changes as a post loadzone task.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2431#comment:15>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development