BIND 10 #2535: handle escaped characters in TXTLikeImpl::toText
BIND 10 Development
do-not-reply at isc.org
Thu Dec 20 11:42:12 UTC 2012
#2535: handle escaped characters in TXTLikeImpl::toText
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner: muks
Type: task | Status:
Priority: medium | reviewing
Component: libdns++ | Milestone:
Keywords: | Sprint-20130108
Sensitive: 0 | Resolution:
Sub-Project: DNS | CVSS Scoring:
Estimated Difficulty: 3 | Defect Severity: N/A
Total Hours: 0 | Feature Depending on Ticket:
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by vorner):
* owner: vorner => muks
Comment:
Hello
It is mostly looking good. However, I think the use of magic constants
isn't
the best thing for readability. Could you provide a comment, saying
something
like „Convert to the \XXX format“ or something? Also, it might be better
to use
'0' instead of 0x30 (I know this is a copy of bind9 code and I think we
can do
better with readability).
--
Ticket URL: <http://bind10.isc.org/ticket/2535#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list