BIND 10 #2535: handle escaped characters in TXTLikeImpl::toText

BIND 10 Development do-not-reply at isc.org
Thu Dec 20 15:58:39 UTC 2012


#2535: handle escaped characters in TXTLikeImpl::toText
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:  muks
                Type:  task          |                       Status:
            Priority:  medium        |  reviewing
           Component:  libdns++      |                    Milestone:
            Keywords:                |  Sprint-20130108
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DNS           |                 CVSS Scoring:
Estimated Difficulty:  3             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by jinmei):

 And one other thing: I just noticed the ticket description wasn't
 clear (sorry about it), but we need to provide an independent routine
 to convert `CharString` (defined in
 dns/rdata/generic/detail/char_string.h) to std::string, escaping some
 characters:

 {{{#!cpp
 // should also go to char_string.{h,cc}
 std::string charStringToStr(CharString& char_str);
 }}}

 Then use it within `TxtLike`.  Character strings are used in some
 other types RDATA than pure `TxtLike` ones, so it should be an
 independent routine.

 changlog should be updated accordingly.  Also, as for changelog, I
 think we should explain the higher level effect of users: as hinted in
 the description, I suspect without this fix TXT-like RDATA are
 effectively unusable from SQLite3 data source, because it will be
 stored in the non-escaped form and createRdata() would reject it.  The
 changelog needs to explain it.  And, for that matter, I'd confirm this
 scenario in a test for datasrc.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2535#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list