BIND 10 #2535: handle escaped characters in TXTLikeImpl::toText
BIND 10 Development
do-not-reply at isc.org
Fri Dec 21 06:31:24 UTC 2012
#2535: handle escaped characters in TXTLikeImpl::toText
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner:
Type: task | vorner
Priority: medium | Status:
Component: libdns++ | reviewing
Keywords: | Milestone:
Sensitive: 0 | Sprint-20130108
Sub-Project: DNS | Resolution:
Estimated Difficulty: 3 | CVSS Scoring:
Total Hours: 0 | Defect Severity: N/A
| Feature Depending on Ticket:
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by muks):
* owner: muks => vorner
Comment:
Replying to [comment:9 vorner]:
> Hello
>
> It is mostly looking good. However, I think the use of magic constants
isn't
> the best thing for readability. Could you provide a comment, saying
something
> like „Convert to the \XXX format“ or something? Also, it might be better
to use
> '0' instead of 0x30 (I know this is a copy of bind9 code and I think we
can do
> better with readability).
I did change the '\' part, but forgot to change the '0' part. :-)
Back to review.
--
Ticket URL: <http://bind10.isc.org/ticket/2535#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list