BIND 10 #1976: use meta-or-container-of data source in b10-auth

[BIND 10 Development]

#1976: use meta-or-container-of data source in b10-auth
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  muks
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120717
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  b10-auth                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  8
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => muks


Comment:

 Hello

 Sorry for such a late response, I forgot to write an answer on Friday :-|.

 Replying to [comment:8 muks]:
 > The following are my review comments. I have read the rest and have not
 found anything could be an issue. However, as I'm looking at a lot of this
 code for the first time as well, I suggest that someone else like Jinmei
 also review this branch. I have reviewed up to commit
 `af4e7787d37b951f9a48e992f0e2c6f4e4a28c22` ([1976] Add missing test file).

 I asked Jelte (as Jinmei was away and also spends more time with the
 research). He seems to have looked at it little bit.

 > * Can only one AuthSrv instance use `DataSourceConfigurator`, if
 `init()` is called with it?

 Yes. As it is a class specific to the b10-auth and that one is not
 designed to have multiple AuthSrv instances anyway.

 > * Why is `DataSourceConfiguratorGeneric::reconfigure()` public?

 For tests, mostly. And, in one of the later branches of #1976, it is
 called at startup as well.

 Replying to [comment:9 jelte]:
 > Not sure if this would disappear when the other branches get involved,
 but shouldn't datasrc_configurator.h's reconfigure() call use
 config->get("classes") (if present) instead of the data directly?

 Yes, that one is fixed somewhere in the following branches (some of the
 yet not reviewed ones).

 > We'll also need to fix #2119 for this to work on my system btw.

 Should it go to next-sprint-proposed, then? Should I rename the python
 file as a workaround?

-- 
Ticket URL: <http://bind10.isc.org/ticket/1976#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development