BIND 10 #2016: search and remove scheduled changes in diff.py

[BIND 10 Development]

#2016: search and remove scheduled changes in diff.py
-------------------------------------+-------------------------------------
                   Reporter:  jelte  |                 Owner:  jelte
                       Type:         |                Status:  reviewing
  defect                             |             Milestone:
                   Priority:         |  Sprint-20120612
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  Unclassified                       |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jelte


Comment:

 Hello

 It looks mostly OK, just the usual bunch of minor glitches.

 It looks like there's some dead code now here:
 {{{#!python
 +            raise dse
              logger.info(LIBDDNS_UPDATE_DATASRC_ERROR, dse)
              return Rcode.SERVFAIL()
 }}}

 It's quite funny that the `__rrset3` contains "one", and so on :-P.

 Should the tests `test_find_updated_other` and
 `test_find_all_other_results` try the original result is not modified even
 if some operations are buffered for the corresponding rrset/name?

 There is some stray whitespace:

 {{{#!python
         self.__rrset7.add_rdata(Rdata(RRType.A(), self.__rrclass,
 "192.0.2.2"))
         ← space here

 }}}

 {{{#!python
     def test_find_all_nonexistent_data(self):
         diff = Diff(self, Name('example.org'), single_update_mode=True)
         diff.add_data(self.__rrset_soa)
         diff.delete_data(self.__rrset_soa)
         ← space here
         self.__create_find_all(ZoneFinder.NXDOMAIN, [], 0)
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/2016#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development