BIND 10 #2016: search and remove scheduled changes in diff.py

[BIND 10 Development]

#2016: search and remove scheduled changes in diff.py
-------------------------------------+-------------------------------------
                   Reporter:  jelte  |                 Owner:  vorner
                       Type:         |                Status:  reviewing
  defect                             |             Milestone:
                   Priority:         |  Sprint-20120612
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  Unclassified                       |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => vorner


Comment:

 Thanks for the review,

 Replying to [comment:6 vorner]:
 >
 > It looks like there's some dead code now here:
 > {{{#!python
 > +            raise dse
 >              logger.info(LIBDDNS_UPDATE_DATASRC_ERROR, dse)
 >              return Rcode.SERVFAIL()
 > }}}
 >

 oops, that raise should not be there (insert usual rant about overactive
 catches hiding debugging info), removed.

 > It's quite funny that the `__rrset3` contains "one", and so on :-P.
 >

 :) i have to confess i got a bit sick of putting in 'foo' and 'bar' etc :)

 > Should the tests `test_find_updated_other` and
 `test_find_all_other_results` try the original result is not modified even
 if some operations are buffered for the corresponding rrset/name?
 >

 good idea, added (and since this used mostly the same checks, that took me
 over the edge to refactor the check-result code into a separate local
 method)

 > There is some stray whitespace:
 >

 I found even more (probably also caused by me), removed them.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2016#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development