BIND 10 #2025: system test for notify

[BIND 10 Development]

#2025: system test for notify
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  muks
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  high   |  Sprint-20120703
                  Component:  xfrin  |            Resolution:
                   Keywords:         |             Sensitive:  0
            Defect Severity:  N/A    |           Sub-Project:  DNS
Feature Depending on Ticket:         |  Estimated Difficulty:  5
        Add Hours to Ticket:  0      |           Total Hours:  0
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => muks


Comment:

 Hello

 Does auth really process the notify, or does it only forward it to some
 other process?
 {{{
 % AUTH_PROCESS_NOTIFY processing incoming NOTIFY for zone name %1, zone
 class %2
 This is a debug message reporting that an incoming NOTIFY is being
 processed.
 }}}

 I think the .toText() calls are not needed here, as the .arg() can take
 whatever has the operator <<:
 {{{#!c++
 .arg(question->getName().toText()).arg(question->getClass().toText());
 }}}

 The `test_notify_slaves` ‒ I don't like the idea of having „test“ options
 in the configuration. Also, what is the difference between this and the
 `also_notify` configuration we plan to have?

 What is the purpose of `transfer_acl` on the `test_notify_slaves`? This is
 for Xfr Out, we are sending the notify out here.

 Also, the lettuce tests failed for me:
 {{{
  Given I have bind10 running with configuration
 xfrin/retransfer_master.conf with cmdctl port 47804 as master #
 features/terrain/bind10_control.py:107
     And wait for master stderr message BIND10_STARTED_CC
 # features/terrain/steps.py:34
     And wait for master stderr message CMDCTL_STARTED
 # features/terrain/steps.py:34
     And wait for master stderr message AUTH_SERVER_STARTED
 # features/terrain/steps.py:34
     And wait for master stderr message XFROUT_STARTED
 # features/terrain/steps.py:34
     And wait for master stderr message ZONEMGR_STARTED
 # features/terrain/steps.py:34
     And I have bind10 running with configuration xfrin/inmem_slave.conf
 # features/terrain/bind10_control.py:107
     And wait for bind10 stderr message BIND10_STARTED_CC
 # features/terrain/steps.py:34
     And wait for bind10 stderr message CMDCTL_STARTED
 # features/terrain/steps.py:34
     And wait for bind10 stderr message AUTH_SERVER_STARTED
 # features/terrain/steps.py:34
     And wait for bind10 stderr message XFRIN_STARTED
 # features/terrain/steps.py:34
     And wait for bind10 stderr message ZONEMGR_STARTED
 # features/terrain/steps.py:34
     A query for www.example.org should have rcode NOERROR
 # features/terrain/querying.py:204
       | """                                                        |
       | www.example.org.        3600    IN      A       192.0.2.63 |
       | """                                                        |
     A query for mail.example.org should have rcode NXDOMAIN
 # features/terrain/querying.py:204
     When I send bind10 the command Xfrin retransfer example.org IN ::1
 47807                                     #
 features/terrain/bind10_control.py:310
     Then wait for new bind10 stderr message XFRIN_TRANSFER_SUCCESS not
 XFRIN_XFR_PROCESS_FAILURE                 # features/terrain/steps.py:34
     Traceback (most recent call last):
       File "/home/vorner/.local/lib64/python2.7/site-
 packages/lettuce/core.py", line 117, in __call__
         ret = self.function(self.step, *args, **kw)
       File
 "/home/vorner/work/bind10/tests/lettuce/features/terrain/steps.py", line
 52, in wait_for_stderr_message
         (found, line) = world.processes.wait_for_stderr_str(process_name,
 strings, new, int(times))
       File
 "/home/vorner/work/bind10/tests/lettuce/features/terrain/terrain.py", line
 342, in wait_for_stderr_str
         matches)
       File
 "/home/vorner/work/bind10/tests/lettuce/features/terrain/terrain.py", line
 242, in wait_for_stderr_str
         strings, only_new, matches)
       File
 "/home/vorner/work/bind10/tests/lettuce/features/terrain/terrain.py", line
 226, in _wait_for_output_str
         assert False, "Timeout waiting for process output: " +
 str(strings)
     AssertionError: Timeout waiting for process output:
 [u'XFRIN_TRANSFER_SUCCESS', u'XFRIN_XFR_PROCESS_FAILURE']
     Then wait for new bind10 stderr message AUTH_LOAD_ZONE
 # features/terrain/steps.py:34
     A query for www.example.org should have rcode NOERROR
 # features/terrain/querying.py:204
     The answer section of the last query response should be
 # features/terrain/querying.py:286
       | """                                                       |
       | www.example.org.        3600    IN      A       192.0.2.1 |
       | """                                                       |
     A query for mail.example.org should have rcode NOERROR
 # features/terrain/querying.py:204
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/2025#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development