BIND 10 #2025: system test for notify

[BIND 10 Development]

#2025: system test for notify
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  high   |  Sprint-20120703
                  Component:  xfrin  |            Resolution:
                   Keywords:         |             Sensitive:  0
            Defect Severity:  N/A    |           Sub-Project:  DNS
Feature Depending on Ticket:         |  Estimated Difficulty:  5
        Add Hours to Ticket:  0      |           Total Hours:  0
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  muks => vorner


Comment:

 Hi vorner

 Replying to [comment:9 vorner]:
 > Does auth really process the notify, or does it only forward it to some
 other process?
 > {{{
 > % AUTH_PROCESS_NOTIFY processing incoming NOTIFY for zone name %1, zone
 class %2
 > This is a debug message reporting that an incoming NOTIFY is being
 processed.
 > }}}
 >

 It is some kind of processing. :) The function where it is logged is
 called `AuthSrvImpl::processNotify()`. I have changed the message id and
 description from processed to received.

 > I think the .toText() calls are not needed here, as the .arg() can take
 whatever has the operator <<:
 > {{{#!c++
 > .arg(question->getName().toText()).arg(question->getClass().toText());
 > }}}

 *nod*. Done.

 > The `test_notify_slaves` ‒ I don't like the idea of having „test“
 options in the configuration. Also, what is the difference between this
 and the `also_notify` configuration we plan to have?

 "test_" is in the key because it is only meant to be used in testing.

 On the difference between this and `also_notify`, I don't know what
 `also_notify` is supposed to do. But `test_notify_slaves` is a list of
 slave addresses which get sent NOTIFYs by Xfrout. It is necessary for
 having this test run under lettuce right now. If `also_notify` is
 implemented in the future, we can revisit this test

 > What is the purpose of `transfer_acl` on the `test_notify_slaves`? This
 is for Xfr Out, we are sending the notify out here.

 Indeed, this was erroneously left in the schema. It was not used. Removed
 now.

 > Also, the lettuce tests failed for me:
 > {{{
 >     When I send bind10 the command Xfrin retransfer example.org IN ::1
 47807
 > }}}

 This is the `inmemory_over_sqlite3.feature` ? Strange that it passed for
 me here! In any case I have made the changes that jinmei suggested about
 address config so it all runs in IPv6.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2025#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development