BIND 10 #1600: Use UDPSyncServer for b10-auth

BIND 10 Development do-not-reply at isc.org
Mon Mar 5 18:17:46 UTC 2012


#1600: Use UDPSyncServer for b10-auth
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  kevin_tes
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  major  |  Sprint-20120306
                  Component:         |            Resolution:
  b10-auth                           |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  5
Feature Depending on Ticket:  auth   |           Total Hours:  0
  performance                        |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 As noted in the ticket description, we also need to make sure the
 `MessageRenderer` is reused within `AuthSrv`, the branch still doesn't
 do that:

 {{{#!c++
 bool
 AuthSrvImpl::processNormalQuery(const IOMessage& io_message, MessagePtr
 message,
                                 OutputBufferPtr buffer,
                                 auto_ptr<TSIGContext> tsig_context)
 ...
     MessageRenderer renderer; // <= temporary renderer is created here.
     renderer.setBuffer(buffer.get());
 ...
 }}}

 What we should do is to have AuthSrvImpl hold a `MessageRenderer`
 object and keep using it for all queries (don't forget adding a test
 to confirm that too).

-- 
Ticket URL: <http://bind10.isc.org/ticket/1600#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list