BIND 10 #1600: Use UDPSyncServer for b10-auth
BIND 10 Development
do-not-reply at isc.org
Tue Mar 6 01:37:47 UTC 2012
#1600: Use UDPSyncServer for b10-auth
-------------------------------------+-------------------------------------
Reporter: | Owner: kevin_tes
jinmei | Status: reviewing
Type: task | Milestone:
Priority: major | Sprint-20120306
Component: | Resolution:
b10-auth | Sensitive: 0
Keywords: | Sub-Project: DNS
Defect Severity: N/A | Estimated Difficulty: 5
Feature Depending on Ticket: auth | Total Hours: 0
performance |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by kevin_tes):
Replying to [comment:11 muks]:
Hi Muks,thanks for the review.
> I propose a few changes to the patch:
>
> * if (1 == foo) {} else if (2 == foo) {} else if ... is better replaced
with switch
ok,if else will be replaced.
> * Instead of the 1, 2, etc. values there, why aren't the UPDVersion enum
values used {SYNC_, ASYNC_}
good point,i'll change that.
> * Some places you use 'param_flags', and in others, 'para_flags'.
'param_flags' is better for both I guess.
All 'para_flags' were replaced by 'param_flags'.
--
Ticket URL: <http://bind10.isc.org/ticket/1600#comment:14>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list