BIND 10 #1136: RR type implementation: SSHFP
BIND 10 Development
do-not-reply at isc.org
Thu Mar 8 15:14:26 UTC 2012
#1136: RR type implementation: SSHFP
-------------------------------------+-------------------------------------
Reporter: shane | Owner: muks
Type: | Status: reviewing
enhancement | Milestone:
Priority: low | Sprint-20120320
Component: | Resolution:
libdns++ | Sensitive: 0
Keywords: | Sub-Project: DNS
Defect Severity: N/A | Estimated Difficulty: 0.0
Feature Depending on Ticket: | Total Hours: 0
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by vorner):
* owner: vorner => muks
Comment:
First, I think this should have a changelog.
And few notes:
* The tests fail, with this error:
{{{
[ RUN ] Rdata_SSHFP_Test.toText
rdata_sshfp_unittest.cc:69: Failure
Value of: rdata_sshfp.toText()
Actual: "2 1 123456789ABCDEF67890123456789ABCDEF67890"
Expected: "2 1 123456789abcdef67890123456789abcdef67890"
[ FAILED ] Rdata_SSHFP_Test.toText (0 ms)
}}}
* Could you provide a test where you test with more than one space to
separate the items and/or different capitalization?
* You have a generated file in git
(src/lib/dns/tests/testdata/rdata_sshfp_fromWire.wire).
* Maybe it could be convenient to have static functions for named
constants for the alorithm and hash.
* There's a file with copyright set to 2010.
--
Ticket URL: <http://bind10.isc.org/ticket/1136#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list