BIND 10 #1136: RR type implementation: SSHFP

[BIND 10 Development]

#1136: RR type implementation: SSHFP
-------------------------------------+-------------------------------------
                   Reporter:  shane  |                 Owner:  muks
                       Type:         |                Status:  reviewing
  enhancement                        |             Milestone:
                   Priority:  low    |  Sprint-20120320
                  Component:         |            Resolution:
  libdns++                           |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  0.0
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by muks):

 Hi vorner

 Thank you for the review. Comments are below:

 Replying to [comment:8 vorner]:
 > First, I think this should have a changelog.

 Done :)

 >
 > And few notes:
 >  * The tests fail, with this error:
 > {{{
 > [ RUN      ] Rdata_SSHFP_Test.toText
 > rdata_sshfp_unittest.cc:69: Failure
 > Value of: rdata_sshfp.toText()
 >   Actual: "2 1 123456789ABCDEF67890123456789ABCDEF67890"
 > Expected: "2 1 123456789abcdef67890123456789abcdef67890"
 > [  FAILED  ] Rdata_SSHFP_Test.toText (0 ms)
 > }}}

 Eek! Thought I had fixed that. The testcase was wrong.. I've added a case
 insensitive compare now.

 >  * Could you provide a test where you test with more than one space to
 separate the items and/or different capitalization?

 Added more tests. :)

 >  * You have a generated file in git
 (src/lib/dns/tests/testdata/rdata_sshfp_fromWire.wire).

 Actually, no.. it was a generated file, but in this case the .spec file
 for that particular testcase is not checked in. But the comment that it
 was generated stayed in the file. I've removed the comment now, and also
 removed the .wire extension to match other static wire data in that dir.

 There are two other .spec files.. they need tests added. I've just kept
 them to test the wiredata generator script.

 >  * Maybe it could be convenient to have static functions for named
 constants for the alorithm and hash.

 Other RR types don't do this either. Maybe we should have a new bug to
 check all of them.

 >  * There's a file with copyright set to 2010.

 Changed the copyright notice in sshfp_44.h :)

-- 
Ticket URL: <http://bind10.isc.org/ticket/1136#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development