BIND 10 #1688: duplicate RR suprression in auth::Query

[BIND 10 Development]

#1688: duplicate RR suprression in auth::Query
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120403
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  b10-auth                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  5
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => jinmei


Comment:

 Replying to [comment:19 jinmei]:
 > I'm not sure if I understand the local method approach...at least I
 > interpreted it as you didn't request a change to the branch by saying
 > this, so I didn't do anything on the code for this part.  If you
 > suggested a specific change, please say so (and clarify the
 > suggestion:-).
 >

 no, i did not request a change, i just noted that had I done it, i would
 probably have not created a new class, but changed the various calls to
 additionals_.push_back(rrset) (and the other two vectors) to a private
 method addRRset(vector&, rrset) which did the duplicate checks, by
 checking all three vectors. It's complexity would've been the same, there
 would be no additional vector to keep track, but the end result might be
 different (in which message section rrsets end up would depend on to which
 section they would've been added first).


 all good, please go ahead and merge :)

-- 
Ticket URL: <http://bind10.isc.org/ticket/1688#comment:21>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development