BIND 10 #1688: duplicate RR suprression in auth::Query

[BIND 10 Development]

#1688: duplicate RR suprression in auth::Query
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120403
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  b10-auth                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  5
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:21 jelte]:

 > no, i did not request a change, i just noted that had I done it, i would
 probably have not created a new class, but changed the various calls to
 additionals_.push_back(rrset) (and the other two vectors) to a private
 method addRRset(vector&, rrset) which did the duplicate checks, by
 checking all three vectors. It's complexity would've been the same, there
 would be no additional vector to keep track, but the end result might be
 different (in which message section rrsets end up would depend on to which
 section they would've been added first).

 So you mean we'd also pass a helper function (or perhaps a functor
 object) to getAdditional()?  I see the possibility, although it may
 not be as efficient as it might look thanks to saving the additional
 storage - calling the helper function for every RRset may not be
 negligible.

 Anyway, this is only for discussion for now.  I've merged the branch,
 and am closing the ticket.

 Thanks,

-- 
Ticket URL: <http://bind10.isc.org/ticket/1688#comment:22>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development