BIND 10 #1892: Check mode of logger

[BIND 10 Development]

#1892: Check mode of logger
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  vorner                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120515
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  logging                            |           Sub-Project:  Core
                   Keywords:         |  Estimated Difficulty:  5
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  muks => vorner


Comment:

 Hi vorner

 Thank you for reviewing my bugs.

 Replying to [comment:7 vorner]:
 > Hello
 >
 > Two small things. First, if the strict mode is not there, we may want to
 preserve the original behaviour with the `@@Missing placeholder`, because
 it at least shows the value, even if it is not obvious where exactly the
 value should be.

 I've added it back. :)

 > Also, I think it is better not to call the checkExcessPlaceholders at
 all if the ENABLE_LOGGER_CHECKS is not enabled, to save the call of empty
 function (eg. adding the #ifdef to the header file too).

 It did occur to me, but that'd involve including config.h into the header
 file which would become a problem if the header is ever installed. This
 single method call isn't a performance blocker for where it's used. I
 think it's fine the way it is.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1892#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development