BIND 10 #1892: Check mode of logger
BIND 10 Development
do-not-reply at isc.org
Thu May 3 10:39:55 UTC 2012
#1892: Check mode of logger
-------------------------------------+-------------------------------------
Reporter: | Owner: muks
vorner | Status: reviewing
Type: task | Milestone:
Priority: | Sprint-20120515
medium | Resolution:
Component: | Sensitive: 0
logging | Sub-Project: Core
Keywords: | Estimated Difficulty: 5
Defect Severity: N/A | Total Hours: 0.67
Feature Depending on Ticket: |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by vorner):
* owner: vorner => muks
* totalhours: 0 => 0.67
Comment:
Hello
Replying to [comment:8 muks]:
> > Also, I think it is better not to call the checkExcessPlaceholders at
all if the ENABLE_LOGGER_CHECKS is not enabled, to save the call of empty
function (eg. adding the #ifdef to the header file too).
>
> It did occur to me, but that'd involve including config.h into the
header file which would become a problem if the header is ever installed.
This single function call isn't a performance blocker for where it's used.
I think it's fine the way it is.
Yes, right. OK, then it looks ready for merge. I just updated the test for
the latest change (so pull first, please).
Will you create a ticket for running everything through the check and
fixing the problems?
Thank you
--
Ticket URL: <http://bind10.isc.org/ticket/1892#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list