BIND 10 #1790: update xfrin to have auth reload transfered zones

[BIND 10 Development]

#1790: update xfrin to have auth reload transfered zones
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120515
  medium                             |            Resolution:
                  Component:  xfrin  |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  3
Feature Depending on Ticket:  xfr    |           Total Hours:  0
  for in-memory                      |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  muks => vorner


Comment:

 Hi vorner

 Replying to [comment:9 vorner]:
 > There's one small problem in the changed code. We have a policy of using
 each log message identifier exactly once, so the place where it was logged
 can be easily identified by grep or something. But you use
 `XFRIN_AUTH_CONFIG_ERROR` at two places.

 Ah.. fixed. :)

 > Well, msgq crashing is considered fatal and can not be changed. If msgq
 quits, the system goes down completely. That's why I think the catch is
 suspicious and should be removed (it is not properly handled error, so the
 error should not be handled at all).

 Do you mean to say that we just don't need to catch the exception at all?

 > > > Why do you switch to IPv4 in the lettuce tests? I believe we had
 both types of addresses to make sure we work with both and if we should
 choose one, it should be the IPv6, not 4 I think.
 > >
 > > The test was configured with 127.0.0.1 in some files and ::1 in other.
 >
 > Not that it would be very important, but as I said, we want to make sure
 both v4 and v6 addresses work correctly, therefore we have a mix of them.

 Actually, what I meant was that the _same test_ had ::1 for xfrout listen
 address in one config file, and 127.0.0.1 in another config file (both for
 where to find xfrout). So I went about changing them to 127.0.0.1 to be
 consistent.

 I think ::1 would cause getaddrinfo() to return addrinfo structs for both
 ::1 and 127.0.0.1 if AF_UNSPEC is passed. But I don't know if this happens
 in the case of xfr* causing it to listen on both.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1790#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development