BIND 10 #1790: update xfrin to have auth reload transfered zones

[BIND 10 Development]

#1790: update xfrin to have auth reload transfered zones
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  muks
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120515
  medium                             |            Resolution:
                  Component:  xfrin  |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  3
Feature Depending on Ticket:  xfr    |           Total Hours:  0
  for in-memory                      |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => muks


Comment:

 Hello

 Replying to [comment:10 muks]:
 > Replying to [comment:9 vorner]:
 > > There's one small problem in the changed code. We have a policy of
 using each log message identifier exactly once, so the place where it was
 logged can be easily identified by grep or something. But you use
 `XFRIN_AUTH_CONFIG_ERROR` at two places.
 >
 > Ah.. fixed. :)

 I also noticed one thing. Does the exception raised contain the
 name/rrclass text that is being used? So the user knows what is wrong?

 > > Well, msgq crashing is considered fatal and can not be changed. If
 msgq quits, the system goes down completely. That's why I think the catch
 is suspicious and should be removed (it is not properly handled error, so
 the error should not be handled at all).
 >
 > Do you mean to say that we just don't need to catch the exception at
 all?

 Yes, that's exactly what I want to say (or, more precisely, that we should
 not catch the exception at all). At least if the exception happens in the
 situation described.

 > > Not that it would be very important, but as I said, we want to make
 sure both v4 and v6 addresses work correctly, therefore we have a mix of
 them.
 >
 > Actually, what I meant was that the _same test_ had ::1 for xfrout
 listen address in one config file, and 127.0.0.1 in another config file
 (both for where to find xfrout). So I went about changing them to
 127.0.0.1 to be consistent.

 Ah, sorry, then I misunderstood.

 And, sorry for bringing it so late, but I noticed there are no tests for
 the branch. Or there are and I don't see them? We definitely should have
 them.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1790#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development