BIND 10 #1790: update xfrin to have auth reload transfered zones
BIND 10 Development
do-not-reply at isc.org
Wed May 9 09:35:47 UTC 2012
#1790: update xfrin to have auth reload transfered zones
-------------------------------------+-------------------------------------
Reporter: | Owner: muks
jinmei | Status: reviewing
Type: task | Milestone:
Priority: | Sprint-20120515
medium | Resolution:
Component: xfrin | Sensitive: 0
Keywords: | Sub-Project: DNS
Defect Severity: N/A | Estimated Difficulty: 3
Feature Depending on Ticket: xfr | Total Hours: 0
for in-memory |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by vorner):
* owner: vorner => muks
Comment:
Hello
I'd have few comments on the new code:
* The naming and description of the tests is not really helpful. Is it
possible to describe what the situation is (eg. the zone is in memory,
therefore it should be notified, etc).
* You probably should use assertTrue and assertFalse instead of
assertEqual(True, …).
* Why is the `_do_auth_loadzone` taken out?
* I don't see any test with broken configuration (eg. unknown filetypes,
missing elements, wrong types of elements).
Thanks
--
Ticket URL: <http://bind10.isc.org/ticket/1790#comment:15>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list