BIND 10 #1790: update xfrin to have auth reload transfered zones

[BIND 10 Development]

#1790: update xfrin to have auth reload transfered zones
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120515
  medium                             |            Resolution:
                  Component:  xfrin  |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  3
Feature Depending on Ticket:  xfr    |           Total Hours:  0
  for in-memory                      |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  muks => vorner


Comment:

 Replying to [comment:15 vorner]:
 >  * The naming and description of the tests is not really helpful. Is it
 possible to describe what the situation is (eg. the zone is in memory,
 therefore it should be notified, etc).

 I have updated the descriptions.

 >  * You probably should use assertTrue and assertFalse instead of
 assertEqual(True, …).

 Done. :)

 >  * Why is the `_do_auth_loadzone` taken out?

 The publish_xfrin_news() method in Xfrin calls _do_auth_loadzone(). As
 part of a different bug, you had added (9a4db008) testcase for
 publish_xfrin_news() which uses a mock method. This bug has to be tested
 when publish_xfrin_news() is called in the same setting. So I had to add a
 call to _do_auth_loadzone() in that method, except that this is not an
 Xfrin derived object but a different mock object. To test it, the actual
 _do_auth_loadzone() implementation had to be called. That's why it had to
 be moved.

 BTW, there are two TestXfrinProcess classes in that file, which you may
 want to look at. 9a4db008 introduced the second.

 >  * I don't see any test with broken configuration (eg. unknown
 filetypes, missing elements, wrong types of elements).

 I've added more tests, but these are really checked by the spec schema
 anyway.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1790#comment:16>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development