BIND 10 #1914: CC library should allow asynchronous waits on messages

[BIND 10 Development]

#1914: CC library should allow asynchronous waits on messages
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  vorner                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120529
  medium                             |            Resolution:
                  Component:  msgq   |             Sensitive:  0
                   Keywords:         |           Sub-Project:  Core
            Defect Severity:  N/A    |  Estimated Difficulty:  8
Feature Depending on Ticket:  msgq-  |           Total Hours:  0
  ng                                 |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => vorner


Comment:

 (btw. I fixed a few typos in comments, and some minor whitespace edits,
 was almost tempted to put in some vertical whitespace as well but resisted
 the urge ;))

 The code looks good, two minor comments; neither really significant;
 - it is slightly more general to check for empty strings using .empty()
 instead of == "" (ccsession.cc:848)
 - perhaps the cancel function could check whether it exists and raise an
 exception, instead of blindly trying to call erase.

 Regarding the location, the original intent was for session.[cc|h] to
 provide a low(er)-level API, and moduleccsession to provide a more or less
 convenient way to perform operations that all or most of them need. As
 such I don't care too much where these are placed. Especially if we want
 to redesign it anyway :)

-- 
Ticket URL: <http://bind10.isc.org/ticket/1914#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development