BIND 10 #1914: CC library should allow asynchronous waits on messages

BIND 10 Development do-not-reply at isc.org
Sat May 19 17:18:57 UTC 2012


#1914: CC library should allow asynchronous waits on messages
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jelte
  vorner                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120529
  medium                             |            Resolution:
                  Component:  msgq   |             Sensitive:  0
                   Keywords:         |           Sub-Project:  Core
            Defect Severity:  N/A    |  Estimated Difficulty:  8
Feature Depending on Ticket:  msgq-  |           Total Hours:  0
  ng                                 |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jelte


Comment:

 Hello

 Replying to [comment:5 jelte]:
 > (btw. I fixed a few typos in comments, and some minor whitespace edits,
 was almost tempted to put in some vertical whitespace as well but resisted
 the urge ;))

 You could have, but maybe it's not important.

 > The code looks good, two minor comments; neither really significant;
 > - perhaps the cancel function could check whether it exists and raise an
 exception, instead of blindly trying to call erase.

 I don't see how it could check so. It could iterate through the whole
 list, but I don't want to do that. And comparing to an invalid iterator is
 undefined operation anyway and it might fail (and it does, if you enable
 the g++ strict checking). Or a new element could have been inserted anyway
 and it could have received the same address, which would make it look like
 it is there. Do you have an idea how to do it properly?

 Thank you

-- 
Ticket URL: <http://bind10.isc.org/ticket/1914#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list