BIND 10 #2369: InputSource helper class for MasterLexer
BIND 10 Development
do-not-reply at isc.org
Thu Nov 1 02:46:09 UTC 2012
#2369: InputSource helper class for MasterLexer
-------------------------------------+-------------------------------------
Reporter: | Owner: muks
jinmei | Status: reviewing
Type: task | Milestone:
Priority: | Sprint-20121106
medium | Resolution:
Component: | Sensitive: 0
libdns++ | Sub-Project: DNS
Keywords: | Estimated Difficulty: 4
Defect Severity: N/A | Total Hours: 0
Feature Depending on Ticket: |
loadzone-ng |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jinmei):
A couple of additional comments:
- As you may have noticed I ended up using (shared) pointers of
`InputSource` to hold them in a vector in `MasterLexer`.
So, if name_ can be initialized in the member initialization list,
it can (and should) be const.
- I suggest renaming "inputsource.{h,cc}" something more specific.
Just saying "input source" sounds too generic.
--
Ticket URL: <http://bind10.isc.org/ticket/2369#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list