BIND 10 #2369: InputSource helper class for MasterLexer
BIND 10 Development
do-not-reply at isc.org
Thu Nov 1 03:20:11 UTC 2012
#2369: InputSource helper class for MasterLexer
-------------------------------------+-------------------------------------
Reporter: | Owner: muks
jinmei | Status: reviewing
Type: task | Milestone:
Priority: | Sprint-20121106
medium | Resolution:
Component: | Sensitive: 0
libdns++ | Sub-Project: DNS
Keywords: | Estimated Difficulty: 4
Defect Severity: N/A | Total Hours: 0
Feature Depending on Ticket: |
loadzone-ng |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jinmei):
Another suggestion:
{{{#!cpp
/// \brief Returns a single character from the input source. If end
/// of file is reached, -1 is returned.
int getChar();
}}}
-1 is probably better than the "EOF" macro, but I'd also like to avoid
using a magic number. I suggest defining some static class constant
to indicate this condition.
--
Ticket URL: <http://bind10.isc.org/ticket/2369#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list