BIND 10 #2369: InputSource helper class for MasterLexer

[BIND 10 Development]

#2369: InputSource helper class for MasterLexer
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  muks
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20121106
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  libdns++                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  4
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
  loadzone-ng                        |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => muks


Comment:

 Hello

 I must admit, the three-way review process is getting me lost gradually.

 Could you, at least, add a TODO note to the saveLine and compact methods
 to
 check if they are needed an possibly make them private?

 With the copyability, I think jinmei mentioned in one of the comments here
 that
 it's no longer needed to be copyable.

 Yes, you can add the explicit keywords to the constructors, though I don't
 think this could ever surprise us (passing an ifstream instead of
 InputSource
 and auto-creating one for us probably won't be a huge problem).

-- 
Ticket URL: <http://bind10.isc.org/ticket/2369#comment:22>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development