BIND 10 #2475: Split libdhcp++ and libdhcp_srv into separate folders.

BIND 10 Development do-not-reply at isc.org
Fri Nov 16 12:44:07 UTC 2012


#2475: Split libdhcp++ and libdhcp_srv into separate folders.
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  stephen
  marcin                             |                Status:  reviewing
                       Type:  task   |             Milestone:  Sprint-
                   Priority:         |  DHCP-20121129
  medium                             |            Resolution:
                  Component:  dhcp   |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DHCP
            Defect Severity:  N/A    |  Estimated Difficulty:  0
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by marcin):

 * owner:  marcin => stephen


Comment:

 The copyright headers should be updated to '''2012''':
 - src/lib/dhcpsrv/tests/run_unittests.cc'''
 - src/lib/dhcpsrv/tests/addr_utilities_unittest/cc

 '''src/lib/dhcpsrv/tests/addr_utilities_unittest.cc'''
 Include of ''dhcpsrv/addr_utilities.h'': Can it be moved before other
 headers?

 '''src/bin/dhcp6/dhcp6_srv.h'''
 Inlusion of ''iostream'': Can ''iostream'' be moved to the end of includes
 list?

 '''src/lib/dhcpsrv/subnet.h'''
 Can boost includes be swapped with project includes?

 '''src/lib/duid.cc'''
 Can stdint.h be moved behind project includes?

 ... at this point I found that many other files in '''src/lib''' still
 have wrong order of includes. Is the reason for this that you aimed to fix
 includes order in only those files that you had to touch anyway when you
 were changing the path to dhcpsrv headers?

 This change should have changelog entry associated with it as it touches
 library/common software that other software may depend on (if any exists
 apart from our server).

-- 
Ticket URL: <http://bind10.isc.org/ticket/2475#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list