BIND 10 #2475: Split libdhcp++ and libdhcp_srv into separate folders.

[BIND 10 Development]

#2475: Split libdhcp++ and libdhcp_srv into separate folders.
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  marcin
  marcin                             |                Status:  reviewing
                       Type:  task   |             Milestone:  Sprint-
                   Priority:         |  DHCP-20121129
  medium                             |            Resolution:
                  Component:  dhcp   |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DHCP
            Defect Severity:  N/A    |  Estimated Difficulty:  0
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => marcin


Comment:

 > The copyright headers should be updated to 2012:
 Updated.

 > at this point I found that many other files in src/lib still have wrong
 order of includes. Is the reason for this that you aimed to fix includes
 order in only those files that you had to touch anyway when you were
 changing the path to dhcpsrv headers?
 That's what I originally did, but in response to your comments, as well as
 the files you mention I thought that I may as well complete the job for
 lib/dhcp, lib/dhcpsrv, bin/dhcp4 and bin/dhcp6 (and the various "test"
 directories). The order of inclusion of header files now follows the
 coding guidelines, being in the order:

 1. config.h
 1. BIND 10 header files.
 1. Package header files. (e.g. Boost, MySQL, GTest)
 1. C++ header files.
 1. C header files.

 I've also altered the {{{#include "xxx.h"}}} forms of the directive to
 {{{#include <directory/xxx.h>}}}, again following the coding guidelines.
 In addition, I checked that the "#include" sentinels conform to the format
 {{{#ifndef FILENAME_H}}}.

 Suggested !ChangeLog entry:
 {{{
 506.    [bug]           stephen
         Split the DHCP source files into two directories, each with its
 own Makefile.
         This properly solves the problem whereby a "make" operation with
 multiple
         threads could fail because of dependencies between the two
 libraries in the
         same directory.
         (Trac #2475, git xxx)
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/2475#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development