BIND 10 #2364: Remove v6 code from the Option::pack4 function.

[BIND 10 Development]

#2364: Remove v6 code from the Option::pack4 function.
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  stephen
  marcin                             |                Status:  reviewing
                       Type:         |             Milestone:  Sprint-
  defect                             |  DHCP-20121129
                   Priority:  low    |            Resolution:
                  Component:  dhcp4  |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DHCP
            Defect Severity:  Low    |  Estimated Difficulty:  0
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by marcin):

 * owner:  marcin => stephen


Comment:

 Reviewed commit b6203bf733422707388f45bc0bece9b3fe40e49d

 '''option.cc'''
 In both pack4 or pack6 functions typo in the following lines
 {{{
 isc_throw(OutOfRange, "Invalid universe type" << universe_);
 }}}
 Need a '''space''' between ''type'' and operator ''<<''

 I have also noticed the following issues also but they can be either fixed
 here or with #2492:

 '''option.h'''
 Suggest that '''@throw OutOfBounds''' tags are added to pack4 and pack6
 doxygen documentation.

 Also '''TODO''' in pack4 documentation should be replaced with '''@todo'''

-- 
Ticket URL: <http://bind10.isc.org/ticket/2364#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development