BIND 10 #2364: Remove v6 code from the Option::pack4 function.

BIND 10 Development do-not-reply at isc.org
Mon Nov 26 13:30:43 UTC 2012


#2364: Remove v6 code from the Option::pack4 function.
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  marcin
  marcin                             |                Status:  reviewing
                       Type:         |             Milestone:  Sprint-
  defect                             |  DHCP-20121129
                   Priority:  low    |            Resolution:
                  Component:  dhcp4  |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DHCP
            Defect Severity:  Low    |  Estimated Difficulty:  0
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => marcin


Comment:

 '''option.cc'''[[BR]]
 > Need a '''space''' between type and operator <<
 Spaces added at points specified and also in a couple of other places.

 '''option.h'''
 > Suggest that @throw !OutOfBounds tags are added to pack4 and pack6
 doxygen documentation.
 Added.  In addition, the exception thrown for a wrong universe in these
 methods has been changed from !OutOfRange to !BadValue.  It is more
 descriptive and matches the exception thrown for the same reason in
 pack().

 > Also TODO in pack4 documentation should be replaced with @todo
 Done.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2364#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list