BIND 10 #2268: some cleanups for in-memory zone load

BIND 10 Development do-not-reply at isc.org
Tue Oct 16 01:30:09 UTC 2012


#2268: some cleanups for in-memory zone load
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  muks
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20121023
  medium                             |            Resolution:
                  Component:  data   |             Sensitive:  0
  source                             |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  5
            Defect Severity:  N/A    |           Total Hours:  5.25
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by muks):

 Replying to [comment:17 jinmei]:
 > Replying to [comment:16 muks]:
 >
 > I'd made one final suggested cleanup: using textToRRset for building
 > test RRsets instead of constructing RRset followed addRdata.  (IMO) it
 > will generally make the code concise and more readable.  I'd also
 > introduce a common variable for the SOA and zone name, but since some
 > of the tests will be moved to a different test case in #2338, I didn't
 > go that further at this time.
 >
 > Whether or not you're okay with this change, the branch is ready for
 > merge.  If you don't like the change for some reason, please simply
 > revert it.
 >
 > I appreciate your patience:-)

 The changes to the tests look fine to me. You know I appreciate the
 patient reviews too. :)

-- 
Ticket URL: <http://bind10.isc.org/ticket/2268#comment:19>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list