BIND 10 #2268: some cleanups for in-memory zone load

[BIND 10 Development]

#2268: some cleanups for in-memory zone load
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  muks
  jinmei                             |                Status:  closed
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20121023
  medium                             |            Resolution:  fixed
                  Component:  data   |             Sensitive:  0
  source                             |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  5
            Defect Severity:  N/A    |           Total Hours:  5.25
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by muks):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 Merged to `master` in commit `83d00dc305a33e69e4bee379895697742a1eaab7`:

 {{{
 * 66524e1 (origin/trac2268) [2268] use textToRRset instead of building
 RRset manually
 * 0e2c140 [2268] Make minor code cleanup
 * 45f0d1f [2168] Untabify
 * 31d0926 [2268] Remove per-test iterator classes and use
 MockVectorIterator instead
 * 3744e7a [2268] Add MockVectorIterator class
 * e93e6f3 [2268] minor editorial cleanups
 * 0e1a1b2 [2268] Remove obsolete comment (the bug was fixed)
 * e2b120a [2268] Move FileNameDeleter out of InMemoryClient
 * 1e6d210 [2268] Update API doc
 * 8b59a7d [2268] Move ZoneDataLoader into an unnamed namespace
 * f176512 [2268] Move ZoneDataLoader class out of its header
 * e77ef46 [2268] Use loadZoneData() inside InMemoryClient
 * 97a6125 [2268] Implement loadZoneData() functions
 * 2150123 [2268] Move ZoneDataLoader to a separate file
 * 6bceaa2 [2268] Rename load method to loadInternal()
 * 65c54c9 [2268] Add a comment about InMemoryClient construction after
 setThrowCount()
 * c1ce544 [2268] Add any attached RRSIGs when loading from an iterator
 * eb84aca [2268] Fix disabled tests without using InMemoryClient::add()
 * 31fdd06 Merge branch 'master' into trac2268
 * ed2b8eb [2268] separated zone data Loader from ZoneDataUpdater.
 * c16c1ab [2268] cleanup: removed (now-)unnecessary include
 * 2eb96fb [2268] constify
 * c6f7cce [2268] doxigen editorial fixes: use \code for code snippet;
 folded a long line
 * 587a136 [2268] Add back logging calls
 * ec2aeca [2268] Fix a leak upon exception in InMemoryClient's constructor
 * 83a27d4 [2268] Remove redundant MemorySegmentTest definition
 * ece0728 [2268] Move constructor and destructor to top of file
 * d050293 [2268] Update ZoneDataUpdater API doc
 * ef49ada [2268] Move EmptyZone exception to InMemoryClient class
 * a475756 [2268] Remove the RdataSet sorting code
 * 27be672 [2268] Just remove obsolete comment
 * 18cff78 [2268] Rename method to addToZoneData()
 * 3402084 [2268] Move LoadCallback typedef to an internal namespace
 * ae53c8f [2268] Move Loader to live under ZoneDataUpdater
 * 97fb03f [2268] Update comment about unnamed namespace
 * 23d2eaf [2268] Use a single NSEC3Hash instance inside ZoneDataUpdater
 * 1137e97 [2268] style fix (brace position) and clarify variable
 (s/set/rdataset/)
 * 12bc898 [2268] even more editorial/style fixes
 * bf382bb [2268] more style/editorial fixes
 * 247cb9c [2268] minor editorial fixes: spacing, combining two short lines
 * 25cd191 [2268] Make all hash related checks use isc::dns::NSEC3Hash
 * e017162 [2268] Remove duplicate copies of NSEC3 check code
 * b3d2730 [2268] Sort oft-used RRTypes to be in front of RdataSet lists
 * b9250ec [2268] Remove unused includes from InMemoryClient implementation
 * 8de1329 [2268] Untabify code
 * 86fcb73 [2268] Remove pimpl from InMemoryClient
 * 61beda1 [2268] Remove unused member variables from
 InMemoryClient::Loader
 * 038ba06 [2268] Use the ZoneDataUpdater in test code too
 * b643e4e [2268] Use ZoneDataUpdater in InMemoryClient
 * 371a652 [2268] Add ZoneDataUpdater class
 }}}

 I've verified that both `make check` and lettuce passed on the merged
 `master` branch.

 Resolving as fixed. Thank you for the reviews Jinmei.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2268#comment:20>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development