BIND 10 #2364: Remove v6 code from the Option::pack4 function.

[BIND 10 Development]

#2364: Remove v6 code from the Option::pack4 function.
-------------------------------+-----------------------------------------
            Reporter:  marcin  |                        Owner:
                Type:  defect  |                       Status:  new
            Priority:  low     |                    Milestone:  DHCP 2012
           Component:  dhcp4   |                     Keywords:
           Sensitive:  0       |              Defect Severity:  Low
         Sub-Project:  DHCP    |  Feature Depending on Ticket:
Estimated Difficulty:  0       |          Add Hours to Ticket:  0
         Total Hours:  0       |                    Internal?:  0
-------------------------------+-----------------------------------------
 The '''Option::pack4''' function in '''src/lib/dhcp/option.cc''' contains
 the switch statement that checks the universe specified for the option
 (DHCPv4 or DHCPv6). Based on this it prepares the on-wire data using
 DHCPv4 format or DHCPv6 format. This seems to be a mistake because pack4
 function can be called (by Option::pack) only if universe is V4. Also, the
 pack4 function is by code's design dedicated to pack DHCPv4 options so
 putting DHCPv6 code there does not makes sense.

 The DHCPv6 code should be removed from Option::pack4.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2364>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development