BIND 10 #2365: Do not reference Option::options_ protected member in derived classes.

[BIND 10 Development]

#2365: Do not reference Option::options_ protected member in derived classes.
-------------------------------+-----------------------------------------
            Reporter:  marcin  |                        Owner:
                Type:  defect  |                       Status:  new
            Priority:  low     |                    Milestone:  DHCP 2012
           Component:  dhcp    |                     Keywords:
           Sensitive:  0       |              Defect Severity:  Low
         Sub-Project:  DHCP    |  Feature Depending on Ticket:
Estimated Difficulty:  0       |          Add Hours to Ticket:  0
         Total Hours:  0       |                    Internal?:  0
-------------------------------+-----------------------------------------
 In the review of #2304 it has been pointed out that classes derived from
 dhcp::Option should not directly reference options_ private member of
 Option. This is the case when derived classes override the pack() method.
 There are two proposed solution to this:
 * define the new method Option::packOptions that can be called in derived
 classes to prepare the on-wire format of sub-options
 * specify the bool parameter in pack4() and pack6() methods that can be
 used to disable packing the data fields - with this parameter the derived
 class could enforce packing sub-options only.

 The separate ticket is being created for this issue because there are
 already a couple of classes derived from Option that should be modified
 (not only those created with #2304).

-- 
Ticket URL: <https://bind10.isc.org/ticket/2365>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development