BIND 10 #2298: Xfrout/zones and XML stats

BIND 10 Development do-not-reply at isc.org
Wed Oct 24 01:57:41 UTC 2012


#2298: Xfrout/zones  and XML stats
-------------------------------------+-------------------------------------
                   Reporter:  jreed  |                 Owner:  UnAssigned
                       Type:         |                Status:  reviewing
  defect                             |             Milestone:
                   Priority:         |  Sprint-20121106
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  statistics                         |           Sub-Project:  Core
                   Keywords:         |  Estimated Difficulty:  5
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by naokikambe):

 Replying to [comment:6 jinmei]:
 > From a quick look, the branch is pretty big, changing many things.
 > Can't it be divided into multiple stages?
 I had to revise the core part of the code for fixing this issue. Handling
 URI of XML was changed. XSD and XSL wasn't dynamically produced. The
 revised code depended on many other parts of the codes. This issue is that
 JSON is appeared in XML. So validating XML data become more strict in
 unittest. And some dirty codes was cleaned. That's why the change became
 big. There are 27 commits in the branch. Probably this ticket was too big
 to be fixed.

 Anyway I tried to group the related changes as the following. Can we
 review codes by group?

 * Handling the uri requested via HTTP
 {{{
 0d35b9 [2298] modify handling the accepted URI
 69f3f5 [2298] append a slash at the end of the URI
 a86eeb [2298] update HTTP status codes
 }}}

 * Handling statistics data returned from the stats daemon and converting
 to an xml format
 {{{
 0a41ff [2298] modify the xml_handler() method
 b1282d [2298] modify test_do_GET() and check_XML_URL_PATH()
 57e21d [2298] update test_xml_handler()
 }}}

 * Revising an xsd format
 {{{
 7a2a76 [2298] modify the xsd template file
 351a2c [2298] modify the xsd_handler() method
 d663e8 [2298] modify test_do_GET() and check_XSD_URL_PATH()
 bc4bdd [2298] modify test_xsd_handler()
 }}}

 * Revising an xsl format
 {{{
 bba782 [2298] modify the xsl template file
 0e0714 [2298] modify test_xsl_handler()
 5286dd [2298] modify test_do_GET() and check_XSL_URL_PATH()
 3c04bb [2298] modify test_xsl_handler()
 }}}

 * adding a helper method
 {{{
 e44e9c [2298] add a method item_name_list()
 68df7d [2298] add constants of XML namespaces for using in tests
 }}}

 * misc changes in b10-stats-httpd
 {{{
 3d17e6 [2298] modify consts related to XML, XSD, and XSL
 65a0f4 [2298] return a 500 status code when catching any exception
 456e69 [2298] append a Last-Modified header
 7e6faa [2298] modify the open_template() method
 }}}

 * misc changes in unittest
 {{{
 d4a9ae [2298] add CONST_BASETIME and use it in MockBoss and MyStats
 classes
 2f26b1 [2298] modify DUMMY_DATA
 f44c42 [2298] use assertGreater() rather than assertTrue()
 d7b7c2 [2298] add a unittest using XML validation with XSD
 753b37 [2298] skip test_do_GET() if XMLParser() is unavailable
 30cf85 [2298] add constants of XML namespaces for using in tests
 }}}

 * updating copyrights
 {{{
 d23d54 [2298] add copyright and update copyrights
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/2298#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list