BIND 10 #2298: Xfrout/zones and XML stats
BIND 10 Development
do-not-reply at isc.org
Thu Oct 25 04:13:53 UTC 2012
#2298: Xfrout/zones and XML stats
-------------------------------------+-------------------------------------
Reporter: jreed | Owner: UnAssigned
Type: | Status: reviewing
defect | Milestone:
Priority: | Sprint-20121106
medium | Resolution:
Component: | Sensitive: 0
statistics | Sub-Project: Core
Keywords: | Estimated Difficulty: 5
Defect Severity: N/A | Total Hours: 0
Feature Depending on Ticket: |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:7 naokikambe]:
> > From a quick look, the branch is pretty big, changing many things.
> > Can't it be divided into multiple stages?
> I had to revise the core part of the code for fixing this issue.
Handling URI of XML was changed. XSD and XSL wasn't dynamically produced.
The revised code depended on many other parts of the codes. This issue is
that JSON is appeared in XML. So validating XML data become more strict in
unittest. And some dirty codes was cleaned. That's why the change became
big. There are 27 commits in the branch. Probably this ticket was too big
to be fixed.
>
> Anyway I tried to group the related changes as the following. Can we
review codes by group?
Perhaps (thanks for the grouping). If I end up reviewing this ticket,
I would like to see a rearranged branch that consist of the grouped
commits that can be followed step by step, since I'm not a guy whose
brain stack is very deep.
I experimentally created a single branch from the branch point of
trac2298 and then cherry-picked the following three commits in that
order:
> * Handling the uri requested via HTTP
> {{{
> 0d35b9 [2298] modify handling the accepted URI
> 69f3f5 [2298] append a slash at the end of the URI
> a86eeb [2298] update HTTP status codes
> }}}
These cleanly merged but tests didn't pass. What I would like to see
is a newly created branch like this and each group is "completed" in
that it (if any .cc/.h involved) compiles and passes all tests. Or,
even preferably, we separate this task into 2-3 subtasks and we review
each subtask one by one. If you're willing to make such changes, that
would be highly appreciated whoever ends up taking on the review.
But, perhaps someone else has a deeper brain capacity than me and may
be able to review the whole branch at once. If you think it's the
case, I'd simply leave the review to that person.
--
Ticket URL: <http://bind10.isc.org/ticket/2298#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list