BIND 10 #2324: Allocation engine v6: address assignment

[BIND 10 Development]

#2324: Allocation engine v6: address assignment
-------------------------------------+-------------------------------------
                   Reporter:  tomek  |                 Owner:  tomek
                       Type:  task   |                Status:  reviewing
                   Priority:         |             Milestone:  Sprint-
  medium                             |  DHCP-20121101
                  Component:  dhcp6  |            Resolution:
                   Keywords:         |             Sensitive:  0
            Defect Severity:  N/A    |           Sub-Project:  DHCP
Feature Depending on Ticket:         |  Estimated Difficulty:  0
        Add Hours to Ticket:  0      |           Total Hours:  0
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by marcin):

 * owner:  marcin => tomek


Comment:

 Replying to [comment:5 tomek]:
 > Replying to [comment:4 marcin]:
 > > '''AllocEngine::Alocator''': there is no need to provide protected
 constructor because '''Allocator''' class is abstract so instance of it
 can't be created anyway (and should be detected in compile time).
 > Removed.

 I missed the fact that virtual destructor is needed in the declaration of
 this class because you have the virtual function and other classes derive
 from it. This should fix the build failure on Fedora17.

 > > '''getLease4X''': IOAddress could be passed as const reference.
 > Also updateLease4/6 was modified. Keep in mind that this is update the
 lease in the database, so the actual passed lease is not updated, so it
 may be constant.

 It appears to me that '''IOAddress''' could be passed by const reference
 to getLeaseX functions as well. For example:
 {{{
 Lease6Ptr getLease6(isc::asiolink::IOAddress addr) const;
 }}}

 could be replaced with:
 {{{
 Lease6Ptr getLease6(const isc::asiolink::IOAddress& addr) const;
 }}}

 The same applies to:
 {{{
 bool deleteLease6(isc::asiolink::IOAddress addr);
 }}}

 Also, in the following functions:
 * getName()
 * getVersion()

 you're missing curly braces in return statement.

 Apart from this, there are some build failures that showed up on the build
 farm:
 * Lack of destructor in AllocEngine::Allocator causing issues on Fedora
 * Lack of constructor in NakedAllocEngine causing issues on Solaris
 * Ambiguous map in alloc_engine_unittest

-- 
Ticket URL: <http://bind10.isc.org/ticket/2324#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development