BIND 10 #2324: Allocation engine v6: address assignment

[BIND 10 Development]

#2324: Allocation engine v6: address assignment
-------------------------------------+-------------------------------------
                   Reporter:  tomek  |                 Owner:  marcin
                       Type:  task   |                Status:  reviewing
                   Priority:         |             Milestone:  Sprint-
  medium                             |  DHCP-20121101
                  Component:  dhcp6  |            Resolution:
                   Keywords:         |             Sensitive:  0
            Defect Severity:  N/A    |           Sub-Project:  DHCP
Feature Depending on Ticket:         |  Estimated Difficulty:  0
        Add Hours to Ticket:  0      |           Total Hours:  0
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by tomek):

 * owner:  tomek => marcin


Comment:

 Replying to [comment:6 marcin]:
 > I missed the fact that virtual destructor is needed in the declaration
 of this class because you have the virtual function and other classes
 derive from it. This should fix the build failure on Fedora17.
 Added.

 > > > '''getLease4X''': IOAddress could be passed as const reference.
 > > Also updateLease4/6 was modified. Keep in mind that this is update the
 lease in the database, so the actual passed lease is not updated, so it
 may be constant.
 >
 > It appears to me that '''IOAddress''' could be passed by const reference
 to getLeaseX functions as well. For example:
 > {{{
 > Lease6Ptr getLease6(isc::asiolink::IOAddress addr) const;
 > }}}
 >
 > could be replaced with:
 > {{{
 > Lease6Ptr getLease6(const isc::asiolink::IOAddress& addr) const;
 > }}}
 Done.

 > The same applies to:
 > {{{
 > bool deleteLease6(isc::asiolink::IOAddress addr);
 > }}}
 Done.

 > Also, in the following functions:
 > * getName()
 > * getVersion()
 >
 > you're missing curly braces in return statement.
 Added.

 > Apart from this, there are some build failures that showed up on the
 build farm:
 > * Lack of destructor in AllocEngine::Allocator causing issues on Fedora
 > * Lack of constructor in NakedAllocEngine causing issues on Solaris
 > * Ambiguous map in alloc_engine_unittest
 I hope to have fixed them all.

 I forgot to add a ChangeLog entry. The last commit fixes that.

 Ok, I think it is now really ready for merge :)

-- 
Ticket URL: <http://bind10.isc.org/ticket/2324#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development