BIND 10 #1545: Use BIND 10 logging in DHCP

[BIND 10 Development]

#1545: Use BIND 10 logging in DHCP
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  stephen
  stephen                            |                Status:  reviewing
                       Type:         |             Milestone:  Sprint-
  enhancement                        |  DHCP-20120917
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:  dhcp   |           Sub-Project:  DHCP
                   Keywords:         |  Estimated Difficulty:  0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by marcin):

 * owner:  marcin => stephen


Comment:

 Reviewed commit 9c0444c02ef367b397f6c189fdba6bab717c7ec3

 '''General comment'''
 "Copyright ... 2011" is to be replaced with "Copyright ... 2012" for new
 files.

 '''src/bin/dhcp4/dhcp4_messages.mes'''
 DHCP4_PACKET_PARSE_FAIL definition: s/include/included

 DHCP4_PACK_FAIL does not take any arguments. The description of the log
 message says that ''Additional messages will detail the reason'' but I
 can't find "additional messages" in the code. This message appears to be
 logged only once in dhcp4_srv.cc (line 146) and no further messages are
 there. Since for the certain number of failures in IfaceMgr we are going
 to throw exceptions we may want to add @todo statement in places where we
 don't yet log the reason of failure saying that we will once #2187 is
 implemented (exception will carry the error string). It would also make
 sense to add TODO comment in .mes file that we are planning to add string
 argument describing the reason for failure for DHCP4_PACK_FAIL and
 DHCP6_PACK_FAIL.

 '''src/bin/dhcp6/dhcp6_srv.h'''
 The doxygen description of serverReceivedPacketName seems to be copied
 from dhcp4_srv.h. Words like DHCPv4, DISCOVER, OFFER should be replaced
 with DHCPv6, SOLICIT, ADVERTISE.

 '''src/bin/dhcp6/tests/dhcp6_srv_unittest.cc'''
 end of file: "oF ANONYMOUS NAMESPACE" could be replaced with "OF ANONYMOUS
 NAMESPACE" or "ANONYMOUS NAMESPACE".

-- 
Ticket URL: <http://bind10.isc.org/ticket/1545#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development