BIND 10 #1545: Use BIND 10 logging in DHCP
BIND 10 Development
do-not-reply at isc.org
Wed Sep 12 14:58:46 UTC 2012
#1545: Use BIND 10 logging in DHCP
-------------------------------------+-------------------------------------
Reporter: | Owner: marcin
stephen | Status: reviewing
Type: | Milestone: Sprint-
enhancement | DHCP-20120917
Priority: | Resolution:
medium | Sensitive: 0
Component: dhcp | Sub-Project: DHCP
Keywords: | Estimated Difficulty: 0
Defect Severity: N/A | Total Hours: 0
Feature Depending on Ticket: |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by stephen):
* owner: stephen => marcin
Comment:
> '''General comment'''
> "Copyright ... 2011" is to be replaced with "Copyright ... 2012" for new
files.
Done
> '''src/bin/dhcp4/dhcp4_messages.mes'''
> DHCP4_PACKET_PARSE_FAIL definition: s/include/included
Done
> DHCP4_PACK_FAIL does not take any arguments...
I had been expecting other messages to be logged somewhere but of course,
with no logging in libdhcp++ there is nowhere they can be logged. I've
modified the message.
> '''src/bin/dhcp6/dhcp6_srv.h'''
> The doxygen description of serverReceivedPacketName seems to be copied
from dhcp4_srv.h. Words like DHCPv4, DISCOVER, OFFER should be replaced
with DHCPv6, SOLICIT, ADVERTISE.
Done
> '''src/bin/dhcp6/tests/dhcp6_srv_unittest.cc'''
> end of file: "oF ANONYMOUS NAMESPACE" could be replaced with "OF
ANONYMOUS NAMESPACE" or "ANONYMOUS NAMESPACE".
Changed.
--
Ticket URL: <http://bind10.isc.org/ticket/1545#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list