BIND 10 #1545: Use BIND 10 logging in DHCP

[BIND 10 Development]

#1545: Use BIND 10 logging in DHCP
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  stephen
  stephen                            |                Status:  reviewing
                       Type:         |             Milestone:  Sprint-
  enhancement                        |  DHCP-20120917
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:  dhcp   |           Sub-Project:  DHCP
                   Keywords:         |  Estimated Difficulty:  0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by marcin):

 * owner:  marcin => stephen


Comment:

 Regarding DHCP4_PACK_FAIL....
 When I am looking at the code of Pkt4::pack() it appears to me that logger
 message will never be printed because Pkt4::pack() always returns true
 (pkt4.cc, line 126). If we want to log the failure it would be better to
 catch exception which may be thrown by LibDHCP::packOptions() (actually
 Option::pack4()). Furthermore, if we catch exception we could use e.what()
 as a failure description but this requires extra parameter to be added to
 DHCP4_PACK_FAIL message.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1545#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development