BIND 10 #1545: Use BIND 10 logging in DHCP

[BIND 10 Development]

#1545: Use BIND 10 logging in DHCP
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  marcin
  stephen                            |                Status:  reviewing
                       Type:         |             Milestone:  Sprint-
  enhancement                        |  DHCP-20120917
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:  dhcp   |           Sub-Project:  DHCP
                   Keywords:         |  Estimated Difficulty:  0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => marcin


Comment:

 You are right about Pkt4::pack().

 It's more complicated with Pkt6::pack() though.  This either throws an
 exception or returns the return status of packTCP()/packUDP().  Ignoring
 packTCP() (not implemented yet), packUDP() returns either true or false,
 the latter if an exception was generated (in which case the exception is
 caught, a message printed to cout, and a value of false returned).

 I think this true/false/exception return status is confusing, so I propose
 that:

 * This is left as-is for now now so that the work can be committed.
 * A new ticket is created to alter the pack() methods in libdhcp++ not to
 return any value (declare them void), but to throw an exception on
 failure.  In the same ticket, the DHCP servers are modified to catch the
 exception and output the (modified) log message with the e.what() value.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1545#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development