BIND 10 #2158: Implement counters into Xfrout (1/3)

[BIND 10 Development]

#2158: Implement counters into Xfrout (1/3)
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  naokikambe
  naokikambe                         |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20120918
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:         |           Sub-Project:  DNS
  xfrout                             |  Estimated Difficulty:  6
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => naokikambe


Comment:

 Just a few minor comments:

 notify_out.py:

 when checking the counter_notifyoutvX arguments, I'd probably raise an
 exception if they are not callable (instead of silently ignoring them).

 I'm also not sure whether putting in a noop callable (lambda: x: None) is
 more efficient than checking for 'is not None' in send_notify_message. (do
 you happen to know if python optimizes that away?)


 xfrout.py[.in]:

 And the same goes for xfrout, btw :)

 There is some dead code at lines 1026 and 1027

 For the rest it looks good

-- 
Ticket URL: <http://bind10.isc.org/ticket/2158#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development