BIND 10 #2158: Implement counters into Xfrout (1/3)

[BIND 10 Development]

#2158: Implement counters into Xfrout (1/3)
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jelte
  naokikambe                         |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20120918
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:         |           Sub-Project:  DNS
  xfrout                             |  Estimated Difficulty:  6
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by naokikambe):

 * owner:  naokikambe => jelte


Comment:

 Hello, thank you for the comments.

 Replying to [comment:10 jelte]:
 > when checking the counter_notifyoutvX arguments, I'd probably raise an
 exception if they are not callable (instead of silently ignoring them).
 >
 > I'm also not sure whether putting in a noop callable (lambda: x: None)
 is more efficient than checking for 'is not None' in send_notify_message.
 (do you happen to know if python optimizes that away?)

 I've updated notify_out.py and xfrout.py not to put in `lambda: x: None`.
 It checks it's not `NoneType` then invokes them. Unless they are callable,
 an exception would be raised. Please see:
 {{{
 2c05e5b [2158] updated counters handling in the classes
 }}}
 Regards,

-- 
Ticket URL: <https://bind10.isc.org/ticket/2158#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development