BIND 10 #2784: perfdhcp cores when given command line "-6" and v4 server address

[BIND 10 Development]

#2784: perfdhcp cores when given command line "-6" and v4 server address
-------------------------------------+-------------------------------------
            Reporter:  tmark         |                        Owner:  tmark
                Type:  defect        |                       Status:
            Priority:  medium        |  reviewing
           Component:  perfdhcp      |                    Milestone:
            Keywords:                |  Sprint-DHCP-20130411
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DNS           |                 CVSS Scoring:
Estimated Difficulty:  0             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => tmark


Comment:

 Reviewed commit 2f3d1fe8c582c75c98b739e0f7b1486b0a9141ca.

 '''tests/tools/perfdhcp/test_control.cc'''
 openSocket: "family" is initialized in one line, then potentially reset a
 couple of lines later after the initialization of "sock", .  Why not
 initialize "family" on one line:
 {{{
 uint8_t family = (options.getIpVersion() == 6) ? AF_INET6 : AF_INET;
 }}}

 "check for mismatch..." - Please start comments with a capital letter.

 In the "if" test following the previously mentioned comment, the
 [wiki:CodingGuidelines#CurlyBraces BIND 10 coding guidelines] indicate
 that the opening brace should be on the same line as the "if".

 In the "isc_throw" statement, the [wiki:CodingGuidelines#TabsIndentation
 coding standards] state that second and subsequent lines should be aligned
 with the opening parenthesis.

 In the "isc_throw" statement, the unstated standard for BIND 10 is to use
 the new C++ construct: "static_cast<unsigned int>" to cast the result of
 options.getIpVersion(), not the old-style C++ casts.

 As the message in isc_throw is printed to the user, the message should be
 perhaps less cryptic: perhaps something like: "The server address
 <address> is not an IPv<version> address as requested by the command-line
 switches".

 The changes will require a !ChangeLog entry as it is user-visible.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2784#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development