BIND 10 #2784: perfdhcp cores when given command line "-6" and v4 server address

[BIND 10 Development]

#2784: perfdhcp cores when given command line "-6" and v4 server address
-------------------------------------+-------------------------------------
            Reporter:  tmark         |                        Owner:
                Type:  defect        |  stephen
            Priority:  medium        |                       Status:
           Component:  perfdhcp      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-DHCP-20130411
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by tmark):

 * owner:  tmark => stephen


Comment:

 Replying to [comment:5 stephen]:
 > Reviewed commit 2f3d1fe8c582c75c98b739e0f7b1486b0a9141ca.
 >
 > '''tests/tools/perfdhcp/test_control.cc'''
 > openSocket: "family" is initialized in one line, then potentially reset
 a couple of lines later after the initialization of "sock", .  Why not
 initialize "family" on one line:
 > {{{
 > uint8_t family = (options.getIpVersion() == 6) ? AF_INET6 : AF_INET;
 > }}}
 >

 Done.

 > "check for mismatch..." - Please start comments with a capital letter.
 >

 Done.

 > In the "if" test following the previously mentioned comment, the
 [wiki:CodingGuidelines#CurlyBraces BIND 10 coding guidelines] indicate
 that the opening brace
  should be on the same line as the "if".
 >

 Old habits, Done.

 > In the "isc_throw" statement, the [wiki:CodingGuidelines#TabsIndentation
 coding standards] state that second and subsequent lines should be aligned
 with the opening parenthesis.
 >

 Done.

 > In the "isc_throw" statement, the unstated standard for BIND 10 is to
 use the new C++ construct: "static_cast<unsigned int>" to cast the result
 of options.getIpVersion(), not the old-style C++ casts.
 >

 Done.  Though one can't really have a standard if it isn't stated.

 > As the message in isc_throw is printed to the user, the message should
 be perhaps less cryptic: perhaps something like: "The server address
 <address> is not an IPv<version> address as requested by the command-line
 switches".
 >
 > The changes will require a !ChangeLog entry as it is user-visible.

 ChangeLog entry proposed in earlier comments, repeated below:

 6xx.    [bug]       tmark
     Perdhcp will now exit gracefully if the command line argument for Ip
 version
     (-4 or -6) does not match the command line argument given for the
 server.
     Prior to this perfdhcp would core when given an Ip version of -6 but a
 valid
     IPv4 address for server.
     (Trac #2784, git TBD)

-- 
Ticket URL: <http://bind10.isc.org/ticket/2784#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development