BIND 10 #2883: discuss/remove class (global) attribute of Counters._statistics

[BIND 10 Development]

#2883: discuss/remove class (global) attribute of Counters._statistics
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  defect        |  naokikambe
            Priority:  medium        |                       Status:
           Component:  statistics    |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130903
         Sub-Project:  Core          |                   Resolution:
Estimated Difficulty:  4             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => naokikambe


Comment:

 Hello

 I have few minor points.

 In the testing spec file, it seems there's a leftover from copy-paste:
 {{{
     "module_name": "NotifyOutLike",
     "module_description": "XFR in daemon",
 }}}

 The description might need some update.

 This code might get simplified, because the spec_file_name is now
 mandatory:
 {{{#!python
         self._statistics_data = {}
         self._statistics_spec = []
         if not spec_file_name: return
         # change the default statistics spec
         self._statistics_spec = \
             isc.config.module_spec_from_file(spec_file_name).\
             get_statistics_spec()
 }}}

 I think this part can be removed completely:
 {{{#!python
         self._statistics_spec = []
         if not spec_file_name: return
         # change the default statistics spec
 }}}

 I don't think it is legal for user to pass None as the spec file name, so
 in that case we can omit the return condition. And then, the default value
 of `[]` will get overwritten right away.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2883#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development