BIND 10 #2883: discuss/remove class (global) attribute of Counters._statistics

[BIND 10 Development]

#2883: discuss/remove class (global) attribute of Counters._statistics
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  defect        |  vorner
            Priority:  medium        |                       Status:
           Component:  statistics    |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130903
         Sub-Project:  Core          |                   Resolution:
Estimated Difficulty:  4             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by naokikambe):

 * owner:  naokikambe => vorner


Comment:

 Hello, thank you for reviewing.

 Replying to [comment:8 vorner]:
 > In the testing spec file, it seems there's a leftover from copy-paste:
 > {{{
 >     "module_name": "NotifyOutLike",
 >     "module_description": "XFR in daemon",
 > }}}
 >
 > The description might need some update.

 I've changed it to another one:
 {{{
 0207a12 [2883] change module_description of a spec file for testing
 }}}

 > This code might get simplified, because the spec_file_name is now
 mandatory:
 > {{{#!python
 >         self._statistics_data = {}
 >         self._statistics_spec = []
 >         if not spec_file_name: return
 >         # change the default statistics spec
 >         self._statistics_spec = \
 >             isc.config.module_spec_from_file(spec_file_name).\
 >             get_statistics_spec()
 > }}}
 >
 > I think this part can be removed completely:
 > {{{#!python
 >         self._statistics_spec = []
 >         if not spec_file_name: return
 >         # change the default statistics spec
 > }}}
 >
 > I don't think it is legal for user to pass None as the spec file name,
 so in that case we can omit the return condition. And then, the default
 value of `[]` will get overwritten right away.

 That's right. I've also update documentation a bit and add a test in case
 of specifying an invalid argument:
 {{{
 8ce213f [2883] None not acceptable for spec_file_name of the Counters
 class
 }}}

 Regards,

-- 
Ticket URL: <http://bind10.isc.org/ticket/2883#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development