BIND 10 #2857: memory manager initial exchanges

BIND 10 Development do-not-reply at isc.org
Fri Aug 23 09:47:34 UTC 2013


#2857: memory manager initial exchanges
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  vorner
            Priority:  medium        |                       Status:
           Component:  shmem         |  reviewing
  manager                            |                    Milestone:
            Keywords:                |  Sprint-20130903
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DNS           |                 CVSS Scoring:
Estimated Difficulty:  5             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |  shared memory data source
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  UnAssigned => vorner


Comment:

 Hi Michal

 * Will the `for item in collection:` syntax not do the same as:
 {{{
         while notifications:
             notification = notifications.pop()
 }}}

 * It would be good to assert that `cmd` is a tuple in
   `_cmd_to_builder()` as it's easy to make a mistake when calling it.

 * Some amount of code comments would be nice in `_notify_from_builder()`
   near the `load-completed` handling: what command `complete_update()`
   would return, that is passed to the builder thread, etc. If some
   developer reads this 6 months from now, they'll not have memory or
   understanding of what is happening.

 * Is it not possible to setup and use a real `DataSrcInfo` for testing?

 * I have pushed some minor commits. Please check them.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2857#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list