BIND 10 #2857: memory manager initial exchanges

[BIND 10 Development]

#2857: memory manager initial exchanges
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:  muks
                Type:  task          |                       Status:
            Priority:  medium        |  reviewing
           Component:  shmem         |                    Milestone:
  manager                            |  Sprint-20130903
            Keywords:                |                   Resolution:
           Sensitive:  0             |                 CVSS Scoring:
         Sub-Project:  DNS           |              Defect Severity:  N/A
Estimated Difficulty:  5             |  Feature Depending on Ticket:
         Total Hours:  0             |  shared memory data source
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => muks


Comment:

 Hello

 Replying to [comment:8 muks]:
 > * Will the `for item in collection:` syntax not do the same as:
 > {{{
 >         while notifications:
 >             notification = notifications.pop()
 > }}}

 I should be less literal in what is written in the ticket description. I
 noticed this idiom with pop in some other ticket too, but here, I just
 copied it without thinking. Anyway, fixed.

 > * It would be good to assert that `cmd` is a tuple in
 >   `_cmd_to_builder()` as it's easy to make a mistake when calling it.

 ACK.

 > * Some amount of code comments would be nice in `_notify_from_builder()`
 >   near the `load-completed` handling: what command `complete_update()`
 >   would return, that is passed to the builder thread, etc. If some
 >   developer reads this 6 months from now, they'll not have memory or
 >   understanding of what is happening.

 ACK.

 > * Is it not possible to setup and use a real `DataSrcInfo` for testing?

 It would be possible, yes. But the amount of work would be significantly
 higher than this mock, because the constructor insists on examining the
 config so I'd have to take care to construct a correct config. And, in the
 end, the code would take the clients_map only, which is just a dict. So it
 sounds to me like wasted effort.

 > * I have pushed some minor commits. Please check them.

 They look OK, thanks.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2857#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development